Improve std-lib-regression script#1360
Merged
celinval merged 2 commits intomodel-checking:mainfrom Jul 12, 2022
Merged
Conversation
Add a dummy proof-harness to it and fix the issue with duplicated lang items that was triggered when trying to resolve the dependencies. The issues seemed to be related to the fact that `kani` crate was built with a different version of the `std` library. For now, we explicitly add the `kani` crate as a dependency so it gets rebuilt with the fresh std.
zhassan-aws
approved these changes
Jul 12, 2022
|
|
||
| # Until we add support to this via our bundle, rebuild the kani library too. | ||
| echo " | ||
| kani = {path=\"${KANI_DIR}/library/kani\"} |
Contributor
There was a problem hiding this comment.
This might be a bit fragile since it depends on adding kani under the [dependencies] section. Perhaps in a future PR, we can rely on https://github.com/killercup/cargo-edit instead?
Contributor
Author
There was a problem hiding this comment.
I agree that this is rather fragile. TBH, I'm really hoping this script will be temporary. We need a better story for std distribution ASAP. Once we do have that, this script should go away and we will likely build (and distribute) the std.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add a dummy proof-harness to it and fix the issue with duplicated lang items that was triggered when trying to resolve the dependencies. The issues seemed to be related to the fact that
kanicrate was built with a different version of thestdlibrary.For now, we explicitly add the
kanicrate as a dependency so it gets rebuilt with the fresh std.Resolved issues:
Resolves #1359
Call-outs:
Testing:
How is this change tested? N/A
Is this a refactor change? N/A
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.