Skip to content

Added packages to release for ubuntu-20.04 only.#1595

Merged
YoshikiTakashima merged 13 commits intomodel-checking:mainfrom
YoshikiTakashima:1587-release-gh-package
Aug 29, 2022
Merged

Added packages to release for ubuntu-20.04 only.#1595
YoshikiTakashima merged 13 commits intomodel-checking:mainfrom
YoshikiTakashima:1587-release-gh-package

Conversation

@YoshikiTakashima
Copy link
Copy Markdown
Contributor

Description of changes:

This PR modifies the release workflow to also push docker images to GHCR. By having these images up in GHCR, users can access kani without compiling it.

Resolved issues:

Resolves #1587

Call-outs:

  • Since running docker images in CI is restricted to linux, I only implemented the image for ubuntu 20.04
  • During testing, make sure to have the

Testing:

  • How is this change tested? Fork the PR branch, then do a fake release to check that the image is uploaded correctly.

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@YoshikiTakashima YoshikiTakashima requested a review from a team as a code owner August 26, 2022 20:19
Copy link
Copy Markdown
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you performed the steps you described in the tests section, right?

Comment thread .github/workflows/release.yml Outdated
@YoshikiTakashima YoshikiTakashima force-pushed the 1587-release-gh-package branch from 42f7a09 to 6a06601 Compare August 27, 2022 01:11
@YoshikiTakashima
Copy link
Copy Markdown
Contributor Author

@YoshikiTakashima YoshikiTakashima merged commit e25a6b8 into model-checking:main Aug 29, 2022
@YoshikiTakashima YoshikiTakashima deleted the 1587-release-gh-package branch August 29, 2022 20:25
@rahulku rahulku added this to the Maintenance milestone Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Release Kani with GH packages.

4 participants