Added packages to release for ubuntu-20.04 only.#1595
Merged
YoshikiTakashima merged 13 commits intomodel-checking:mainfrom Aug 29, 2022
Merged
Added packages to release for ubuntu-20.04 only.#1595YoshikiTakashima merged 13 commits intomodel-checking:mainfrom
YoshikiTakashima merged 13 commits intomodel-checking:mainfrom
Conversation
4 tasks
celinval
approved these changes
Aug 26, 2022
Contributor
celinval
left a comment
There was a problem hiding this comment.
I'm assuming you performed the steps you described in the tests section, right?
tedinski
reviewed
Aug 26, 2022
42f7a09 to
6a06601
Compare
added 8 commits
August 26, 2022 21:26
Contributor
Author
|
@celinval At the time of the PR, it was untested b/c I wanted to get feedback quickly. Now it's tested
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR modifies the release workflow to also push docker images to GHCR. By having these images up in GHCR, users can access kani without compiling it.
Resolved issues:
Resolves #1587
Call-outs:
Testing:
How is this change tested? Fork the PR branch, then do a fake release to check that the image is uploaded correctly.
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.