Install Kani into the action, instead of using a docker#1724
Install Kani into the action, instead of using a docker#1724danielsn wants to merge 7 commits intomodel-checking:mainfrom
Conversation
40eb967 to
c24e320
Compare
6c6f8fd to
bbbe169
Compare
bbbe169 to
eb0af4b
Compare
There was a problem hiding this comment.
I do have one concern regarding how we are using our repository. I was puzzled about having the action.yml in the root of the repository. So I decided to read a bit more about actions. This is basically the first thing in their documentation:
When you plan to publish your action to GitHub Marketplace, you'll need ensure that the repository only includes the metadata file, code, and files necessary for the action.
https://docs.github.com/en/actions/creating-actions/publishing-actions-in-github-marketplace
| # Copyright Kani Contributors | ||
| # SPDX-License-Identifier: Apache-2.0 OR MIT | ||
| name: Kani Action Check | ||
| on: pull_request |
|
That's a pretty good point. We should have a |
| - name: Install Kani | ||
| shell: bash | ||
| run: | | ||
| export KANI_VERSION="0.11.0"; \ |
There was a problem hiding this comment.
Should we retrieve the version from the repository instead? I was also wondering if we should allow users to choose the version they want to use so they can control when to update Kani.
There was a problem hiding this comment.
My thought was action version matches kani-version. So we have kani-action@0.11 matches kani 0.11
|
@danielsn Can we close this PR since we have published the Action in a different repo? |
Description of changes:
Currently, the action requires a docker, which is not yet published. Instead, as a temporary solution, just install the dependencies every time.
Resolved issues:
Resolves #1589
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested? Made a repo with Kani proofs, ran this action on it.
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.