feat: Make OAuth callback URIs configurable #585
+284
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxcoppell
changed the title
This makes the MCP Inspector's OAuth 2.0 callback URIs configurable via environment variables (OAUTH_MCP_INSPECTOR_CALLBACK, OAUTH_MCP_INSPECTOR_DEBUG_CALLBACK). This is useful for environments where the Inspector is running behind a proxy or in a containerized setup with a different public-facing URL. The server listens on the ports specified in these URLs and forwards OAuth2 authorization codes to the Inspector frontend.
mxcoppell
force-pushed
the
feature/oauth-flow
branch
from
a0beb17 to
f2ed9c9
Compare
olaservo
reviewed
Jul 7, 2025
package.json
Outdated
| @@ -56,6 +56,7 @@ | |||
| "zod": "^3.23.8" | |||
| }, | |||
| "devDependencies": { | |||
| "@modelcontextprotocol/inspector": "^0.15.0", | |||
There was a problem hiding this comment.
Why does Inspector need to be added as a dev dependency here?
The package was incorrectly listing itself as a dev dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the MCP Inspector's OAuth 2.0 callback URIs configurable.
Previously, the callback URIs were hardcoded. This change allows them to be set dynamically, which is useful for environments where the Inspector is running behind a proxy or in a containerized setup with a different public-facing URL.
The implementation reads the callback URI from sessionStorage, which can be populated from environment variables on the server at startup. Specifically, the following keys are used:
OAUTH_MCP_INSPECTOR_CALLBACKfor the standard OAuth flow.OAUTH_MCP_INSPECTOR_DEBUG_CALLBACKfor the OAuth debugging flow.If these session storage items are not set, the Inspector falls back to the default URIs (
/oauth/callbackand/oauth/callback/debug).