feat(schema): add support for JSON Schema $defs and definitions #146
+132
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for $defs and definitions properties in JsonSchema record to handle JSON Schema references properly. Added tests to verify both formats work correctly. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
mcp/src/test/java/io/modelcontextprotocol/spec/McpSchemaTests.java
Outdated
Show resolved
Hide resolved
Changed the JsonSchema test approach to use serialization/deserialization round-trip validation instead of property-by-property assertions. This makes tests more maintainable and less likely to break when new properties are added. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for $defs and definitions properties in JsonSchema record to handle JSON Schema references properly. Added tests to verify both formats work correctly.
🤖 Generated with Claude Code
Motivation and Context
This change addresses issue #145 by adding support for both
$defsanddefinitionsproperties in the JsonSchema record. Previously, the schema couldn't properly handle JSON Schema references that use these properties,which are essential for defining complex schema structures with reusable components.
How Has This Been Tested?
Added comprehensive unit tests that verify:
$defspropertydefinitionspropertyBreaking Changes
None. This is a backward-compatible enhancement to the existing JsonSchema implementation.
Types of changes
Checklist
Additional context
This implementation supports both the older
definitionskeyword and the newer$defskeyword (introduced in JSON Schema draft 2019-09) to ensure compatibility with different JSON Schema versions.