chore: pass explicit validate= to root Container() in tests and README#29
Merged
Conversation
The upcoming modern-di 2.x minor emits an UnvalidatedContainerWarning (FutureWarning) when a root container is built without an explicit validate argument. Passing validate=True everywhere future-proofs the suite and README against that warning noise and dogfoods graph validation ahead of time. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Passes an explicit
validate=to every bare rootmodern_di.Container(...)construction in this repo's tests and README.md (5 test sites + 1 README example).build_child_containercalls are untouched — only root constructions acceptvalidate.All sites use
validate=True; none of the graphs here are intentionally invalid, so novalidate=Falseexceptions were needed.Why
The next
modern-di2.x minor introducesUnvalidatedContainerWarning(aFutureWarning) when a root container is built without an explicitvalidateargument. Passing it explicitly future-proofs the suite and README against warning noise and dogfoods graph validation. The warning isn't asserted here since the currently pinnedmodern-direlease doesn't emit it yet.Test plan
just test-ci— 14 passed, 100% coveragejust lint-ci— ruff format/check, ty, planning index all pass🤖 Generated with Claude Code