Skip to content

List of possible features to implement #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lesnik512 opened this issue Mar 21, 2024 · 4 comments
Closed

List of possible features to implement #6

lesnik512 opened this issue Mar 21, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@lesnik512
Copy link
Member

lesnik512 commented Mar 21, 2024

  1. Injecting factory itself Injecting factory itself #27
  2. Configuration provider Configuration provider #30
  3. Object provider Object provider #28
  4. Dict provider Dict provider #29
  5. Selector provider done in Selector provider #32
  6. Allow dynamic attributes assignment in container Allow dynamic attributes assignment in container #33
@lesnik512 lesnik512 added the enhancement New feature or request label Mar 21, 2024
@lesnik512 lesnik512 self-assigned this Apr 21, 2024
@vrslev
Copy link
Collaborator

vrslev commented May 16, 2024

Can those features be implemented in a way that wouldn't break type checking and require typing.cast() usage?

@lesnik512
Copy link
Member Author

I think so. Good type checking is one of the basic ideas of this package.
I'm not sure, that we need all these features. It's just some ideas for the future.

For example, I don't like configuration provider and thinking about injecting whole settings object or separating it into smaller singletons instead of configuration provider

@lesnik512 lesnik512 changed the title Make a list of good features of dependency-injector to implement List of possible features to implement May 25, 2024
@jasonprado
Copy link
Contributor

  1. Injecting a factory–I use that a lot. I like the way pdi fills in args for you when it gives you a Factory in a caller.
  2. The way pdi does configuration isn't great. I use pydantic-settings v2 and to get it into a Configuration object in pdi I had to hack it + you lose type safety. Seems hard but would be so great to solve!
  3. I use Selector a lot, it's a great feature.

I'm stoked to see this project coming along! If any of these sound like good starter tasks I'd be interested in trying one out. I'm using pdi in production at my job and need a path forward!

@lesnik512
Copy link
Member Author

Thank you, Jason! Great to hear, that this project can became useful not only for my projects.

I will split this issue into parts and will write ideas, how they can be implemented, so anyone can contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants