Skip to content

Dict provider #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lesnik512 opened this issue Jun 8, 2024 · 2 comments · Fixed by #35
Closed

Dict provider #29

lesnik512 opened this issue Jun 8, 2024 · 2 comments · Fixed by #35
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lesnik512
Copy link
Member

https://python-dependency-injector.ets-labs.org/providers/dict.html

Very similar to https://that-depends.readthedocs.io/providers/list.html

@lesnik512 lesnik512 added the good first issue Good for newcomers label Jun 8, 2024
@lesnik512 lesnik512 added the enhancement New feature or request label Jun 8, 2024
@Denis-Frunza
Copy link
Contributor

@lesnik512 Is it possible to start working on this improvement? Are there any particular rules I need to know before opening a PR?

@lesnik512
Copy link
Member Author

lesnik512 commented Jun 14, 2024

@Denis-Frunza yes, it would be great!
It's better to put this provider here with List https://github.com/modern-python/that-depends/blob/main/that_depends/providers/collections.py

And here is small guide for contributors https://that-depends.readthedocs.io/dev/contributing.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants