Skip to content

Add a new class DictProvider to handle a dictionary of values. #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Add a new class DictProvider to handle a dictionary of values. #35

merged 1 commit into from
Jun 15, 2024

Conversation

Denis-Frunza
Copy link
Contributor

MR adds a new class DictProvider to the codebase, which allows for handling dictionary values and resolving them asynchronously or synchronously.

Issue: #29

@Denis-Frunza
Copy link
Contributor Author

@lesnik512 could you take a look, please? If it's okay I'll add the tests and docs as well.

@lesnik512 lesnik512 linked an issue Jun 14, 2024 that may be closed by this pull request
@lesnik512
Copy link
Member

@Denis-Frunza looks great

@Denis-Frunza
Copy link
Contributor Author

@lesnik512 I've added some docs. Also, I planned to add tests, but it seems the containers don't have any tests.

@lesnik512 lesnik512 merged commit 5152b04 into modern-python:main Jun 15, 2024
4 checks passed
@lesnik512
Copy link
Member

@Denis-Frunza thank you! I merged it and wrote simple test. And released it https://github.com/modern-python/that-depends/releases/tag/1.12.0

@Denis-Frunza Denis-Frunza deleted the 29-dict-provider branch June 22, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dict provider
2 participants