Skip to content

test_HDFStore uses hardcoded absolute filename which breaks parallel test sessions #2527

Closed
@vnlitvinov

Description

@vnlitvinov

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): any Linux
  • Modin version (modin.__version__): current master (2592849)
  • Python version: any
  • Code we can use to reproduce: create a read-only file /tmp/test_read_hdf.hdf5 and run test_io.py::test_HDFStore

Describe the problem

Pandas up to (including) 1.1.5 use some "funny" logic when opening a HDFStore - if opening in write mode fails it silently (well, it prints to stdout which itself is a strange decision for a library) opens the store in read-only mode.
So if the file exists and, for example, was created by another user, all other test sessions on that box would fail.

This was fixed in Pandas via pandas-dev/pandas#36859, but that isn't released yet.

Source code / logs

Current proposal: do not use hardcoded absolute path for the store.

cc @YarShev

Metadata

Metadata

Assignees

Labels

Testing 📈Issues related to testingbug 🦗Something isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions