Skip to content

fix(processors): normalize string 'true'/'false' to boolean in getProperty #16888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ibochkarev wants to merge 7 commits into
base: 3.x
Choose a base branch
from
+4 −3
Open

fix(processors): normalize string 'true'/'false' to boolean in getProperty #16888

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
81e30e2
fix(processors): normalize string 'true'/'false' to boolean in getPro…
Ibochkarev Feb 24, 2026
516fac6
Update core/src/Revolution/Processors/Processor.php
Ibochkarev Feb 25, 2026
8cd8708
Update core/src/Revolution/Processors/Processor.php
Ibochkarev Feb 25, 2026
bfe970c
Update core/src/Revolution/Processors/Processor.php
Ibochkarev Feb 25, 2026
c928dc5
fix(processors): add getBooleanProperty(), keep getProperty() unchanged
Ibochkarev Feb 25, 2026
858d4af
Update core/src/Revolution/Processors/Resource/Get.php
Ibochkarev May 20, 2026
205c2c1
refactor: address PR review — keep only Resource/Get fix
Ibochkarev Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions core/src/Revolution/Processors/Resource/Get.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?php

/*
* This file is part of MODX Revolution.
*
Expand Down Expand Up @@ -30,8 +31,8 @@ public function process()
{
$resourceArray = $this->object->toArray();
$resourceArray['canpublish'] = $this->modx->hasPermission('publish_document');
if (!$this->getProperty('skipFormatDates') ||
($this->getProperty('skipFormatDates') && $this->getProperty('skipFormatDates') == 'false')) {
$skipFormatDates = $this->modx->paramValueIsTrue($this->getProperties(), 'skipFormatDates');
if (!$skipFormatDates) {
$this->formatDates($resourceArray);
}
return $this->success('', $resourceArray);
Expand All @@ -51,7 +52,7 @@ public function formatDates(array &$resourceArray)
} else {
$resourceArray['unpub_date'] = '';
}
if (!empty($resourceArray) && $resourceArray['publishedon'] != '0000-00-00 00:00:00') {
if (!empty($resourceArray['publishedon']) && $resourceArray['publishedon'] != '0000-00-00 00:00:00') {
$resourceArray['publishedon'] = date($format, strtotime($resourceArray['publishedon']));
} else {
$resourceArray['publishedon'] = '';
Expand Down
Loading