Skip to content

fix: drop ShellJS in favor of child_process #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2021
Merged

fix: drop ShellJS in favor of child_process #2

merged 1 commit into from
Sep 26, 2021

Conversation

drakhart
Copy link
Contributor

This fixes #1 by avoiding shelljs/shelljs#1024 and still leaves the original functionality intact.

moejetz
moejetz approved these changes Sep 26, 2021
View reviewed changes
Copy link
Owner

@moejetz moejetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drakhart,
thanks for the fix! Tested and approved :)

@moejetz moejetz merged commit 980d562 into moejetz:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moejetz moejetz moejetz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to run shell command
2 participants
@drakhart @moejetz