Skip to content

chore(utils-reasoning)!: deprecate#290

Merged
kwaa merged 4 commits intomainfrom
chore/deprecate-utils-reasoning
May 5, 2026
Merged

chore(utils-reasoning)!: deprecate#290
kwaa merged 4 commits intomainfrom
chore/deprecate-utils-reasoning

Conversation

@kwaa
Copy link
Copy Markdown
Member

@kwaa kwaa commented May 5, 2026

No description provided.

@kwaa kwaa requested a review from nekomeowww May 5, 2026 05:46
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds deprecation notices to the extractReasoningStream and extractReasoning utilities. The review highlights significant concerns regarding these deprecations, noting that the suggested replacements are not functional substitutes due to architectural coupling and differences in how reasoning is parsed from content streams versus native API fields. Additionally, a syntax error was identified in the extractReasoning deprecation message, which has been addressed with a provided code suggestion.

Comment thread packages/utils-reasoning/src/extract-reasoning-stream.ts
Comment thread packages/utils-reasoning/src/extract-reasoning.ts Outdated
kwaa and others added 2 commits May 5, 2026 13:49
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@kwaa kwaa merged commit 63c358b into main May 5, 2026
4 checks passed
@kwaa kwaa deleted the chore/deprecate-utils-reasoning branch May 5, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant