Skip to content

[#54] java8 features #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bmarwell merged 6 commits into from
Jan 25, 2022
Merged

[#54] java8 features #59

bmarwell merged 6 commits into from
Jan 25, 2022

Conversation

@bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Jan 24, 2022

fixes #54

@bmarwell bmarwell added the internal Maintenance, e.g. code quality label Jan 24, 2022
@bmarwell bmarwell marked this pull request as ready for review January 24, 2022 21:58
@bmarwell bmarwell requested a review from khmarbaise January 24, 2022 21:58
@olamy
Copy link
Member

olamy commented Jan 24, 2022

not related to this but I would prefer we use the shared release drafter configuration file from https://github.com/mojohaus/.github with such configuration https://github.com/mojohaus/exec-maven-plugin/blob/master/.github/release-drafter.yml

@bmarwell
Copy link
Contributor Author

bmarwell commented Jan 25, 2022

not related to this but I would prefer we use the shared release drafter configuration file from https://github.com/mojohaus/.github with such configuration https://github.com/mojohaus/exec-maven-plugin/blob/master/.github/release-drafter.yml

Will do, I didn't understand that the "extends:" statement references a local repo.
Will update the tags accordingly. 👍🏻

@bmarwell bmarwell merged commit fb671a0 into master Jan 25, 2022
@bmarwell bmarwell deleted the #54_java8_features branch January 25, 2022 20:13
@slawekjaranowski slawekjaranowski added this to the v3.1.0 milestone Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olamy olamy olamy left review comments

@slachiewicz slachiewicz slachiewicz approved these changes

@khmarbaise khmarbaise Awaiting requested review from khmarbaise

Assignees

No one assigned

Labels

internal Maintenance, e.g. code quality

Projects

None yet

Milestone

v3.1.0

Development

Successfully merging this pull request may close these issues.

Convert to Java 8 language features (Generics, boxing, for loops, etc)

4 participants

@bmarwell @olamy @slachiewicz @slawekjaranowski