Skip to content

fix(cron): add delay_ms to avoid LLM computing absolute timestamps #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
penso merged 1 commit into from
Mar 10, 2026
Merged

fix(cron): add delay_ms to avoid LLM computing absolute timestamps #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions crates/tools/src/cron_tool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,18 @@ fn normalize_schedule_value(schedule: &mut Value) -> Result<()> {
"timeMs",
"time_ms",
]);
// Resolve delay_ms (relative offset from now) into an absolute at_ms.
// This lets the LLM specify "in 10 minutes" without computing epoch timestamps.
take_alias(obj, "delay_ms", &["delayMs", "delay", "in", "in_ms", "offset_ms"]);
Comment thread
Devansh-bit marked this conversation as resolved.
if let Some(delay_raw) = obj.remove("delay_ms") {
let delay = parse_interval_millis(&delay_raw, "schedule.delay_ms")?;
let now = std::time::SystemTime::now()
.duration_since(std::time::UNIX_EPOCH)
.unwrap_or_default()
.as_millis() as u64;
obj.entry("at_ms".to_string()).or_insert(json!(now + delay));
Comment thread
Devansh-bit marked this conversation as resolved.
obj.entry("kind".to_string()).or_insert(json!("at"));
Comment thread
Devansh-bit marked this conversation as resolved.
}
take_alias(obj, "every_ms", &[
"everyMs",
"every",
Expand Down Expand Up @@ -649,10 +661,11 @@ impl AgentTool for CronTool {
"name": { "type": "string", "description": "Human-readable job name" },
"schedule": {
"type": "object",
"description": "Schedule object. Use {kind:'at', at_ms}, {kind:'every', every_ms, anchor_ms?}, or {kind:'cron', expr, tz?}. This tool also accepts shorthand schedule strings/numbers at runtime.",
"description": "Schedule object. For one-off jobs use {kind:'at', delay_ms} where delay_ms is milliseconds from now (e.g. 600000 for 10 min) — never compute at_ms yourself. For recurring use {kind:'every', every_ms} or {kind:'cron', expr, tz?}.",
"properties": {
"kind": { "type": "string", "enum": ["at", "every", "cron"] },
"at_ms": { "type": "integer", "description": "Used when kind='at'" },
"delay_ms": { "type": "integer", "description": "Milliseconds from now to run the job (server resolves to absolute time). Preferred over at_ms." },
"at_ms": { "type": "integer", "description": "Absolute epoch milliseconds. Use delay_ms instead unless you have an exact timestamp." },
"every_ms": { "type": "integer", "description": "Used when kind='every'" },
"anchor_ms": { "type": "integer", "description": "Optional anchor when kind='every'" },
"expr": { "type": "string", "description": "Cron expression used when kind='cron'" },
Expand Down