feat(deps)!: update Node.js to v20 #214
Open
+20
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… workflow run max run time
Anemy
commented
Jun 4, 2025
.github/workflows/nodejs.yml
Outdated
| @@ -11,19 +11,20 @@ name: CI | |||
| jobs: | |||
| test: | |||
| name: Test | |||
| timeout-minutes: 10 | |||
There was a problem hiding this comment.
Looks like these tests don't cleanup fully. To prevent them running 360 minutes I'm adding this. Not fixing the root in these changes, likely that'll be saved for another time.
Yeah, bumping the minimum Node.js requirement is definitely a Practically speaking, I don't think we can bump to 22 yet, not until mongosh is also at a newer (20+) version of Node.js. That will likely happen later this year, though. |
Anemy
changed the title
github-actions
bot
added
breaking
feature
and removed
ignore-for-release
feature
breaking
labels
|
@Anemy You could lower the target to 20.x and add testing for 22.x and 24.x – would that work for now? |
|
@Anemy took the liberty to push a commit to change the minimum to the latest 20.x |
addaleax
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re @addaleax's comment, let's wait until mongosh is on node 22 before we merge this.
*edit, we can go to 20 and add this testing as Anna suggested, will update.