-
Notifications
You must be signed in to change notification settings - Fork 0
feat(deps)!: update Node.js to v20 #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… workflow run max run time
.github/workflows/nodejs.yml
Outdated
@@ -11,19 +11,20 @@ name: CI | |||
jobs: | |||
test: | |||
name: Test | |||
timeout-minutes: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these tests don't cleanup fully. To prevent them running 360 minutes I'm adding this. Not fixing the root in these changes, likely that'll be saved for another time.
Yeah, bumping the minimum Node.js requirement is definitely a Practically speaking, I don't think we can bump to 22 yet, not until mongosh is also at a newer (20+) version of Node.js. That will likely happen later this year, though. |
@Anemy You could lower the target to 20.x and add testing for 22.x and 24.x – would that work for now? |
@Anemy took the liberty to push a commit to change the minimum to the latest 20.x |
Re @addaleax's comment, let's wait until mongosh is on node 22 before we merge this.
*edit, we can go to 20 and add this testing as Anna suggested, will update.