Skip to content

INTPYTHON-380 Add typing #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

blink1073
Copy link
Member

Fixes #129

Copy link
Collaborator

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@@ -182,14 +182,14 @@

# -- Options for LaTeX output --------------------------------------------------
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you removing the section? what's happening here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an empty dict, which tripped up the type checker, so I just commented out to use the default value.

@blink1073 blink1073 merged commit f66cdb9 into mongodb-labs:main Jan 14, 2025
20 checks passed
@blink1073 blink1073 deleted the INTPYTHON-380-typing branch January 14, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use mypy
2 participants