Re-export bson lib #290
Re-export bson lib #290
Conversation
|
Awesome! 👏 |
There was a problem hiding this comment.
Well, I'm happy to report that I was able to pull this branch locally, test it against the wither crate, and all tests, including compiler tests (for the custom derive) passed. All testing was on stable Rust 2015.
Pretty much all that needed to happen was updating extern crate statements and putting the #[macro_use] on top of the extern crate mongodb;, as expected.
Great work!
Co-Authored-By: kyeah <[email protected]>
|
This is vital to me, any ETA on merge? |
There was a problem hiding this comment.
Apologies, I completely missed this PR until now. I think after Rust 2018 comes out (which will be in 1.31, the next stable version), we should look into using the local_inner_macros attribute to allow users to just import doc! (and not need to import bson! as well). It's described in more detail here; specifically, it'll make it usable both for users on 2015 edition and 2018 edition.
That being said, I see no reason to block this on that release, as it still works for everybody on the currently released version. Thanks for doing this @kyeah!
|
Merged; I'll make a release tonight if @saghm doesn't get to it before me. |
|
Awesome, you guys are the best! 👍 |
Closes #281.
This converts usage of
macro_useinto explicit imports ofuse bson::{bson, doc}.Also re-exports bson::* to remove downstream requirements of installing the correct version of bson.
Cut as version 0.3.11.
cc. @H2CO3