(EAI-419): Fix broken langchain wrapper #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlarew
reviewed
Jul 15, 2024
| @@ -20,22 +13,4 @@ describe("LangChainEmbedder", () => { | |||
| const result = await embedder.embed({ text: "hello" }); | |||
| expect(result).toEqual({ embedding: [1, 2, 3] }); | |||
| }); | |||
| it("works with Azure OpenAI", async () => { | |||
There was a problem hiding this comment.
Does this have any implications around our support for Azure OpenAI? I'm assuming we still support it and just don't want a special test case?
There was a problem hiding this comment.
correct.
it requires slightly different configuration than our standard azure openai wrapper. it'd be more work than worth doing to explicitly test this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.mongodb.org/browse/EAI-419
Changes
Notes