Skip to content

(EAI-604): Fix NDCG metric #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 12, 2024
Merged

(EAI-604): Fix NDCG metric #555

merged 4 commits into from
Nov 12, 2024

Conversation

mongodben
Copy link
Collaborator

Jira: https://jira.mongodb.org/browse/EAI-604

Changes

  • Fix NDCG metric
  • Refactor NDCG for readability
  • Make tests more precise w/ clearer names

Notes

  • the problem was that the denominator of ideal DCG was being calculated incorrectly. it was including at most the actual number of correct documents in ideal order, but not the total number of possible documents. this kept the ideal number smaller, skewing the metric upwards.

@mongodben mongodben merged commit 6098b7b into main Nov 12, 2024
1 check passed
@mongodben mongodben deleted the EAI-604 branch November 12, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlarew nlarew nlarew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mongodben @nlarew