(EAI-1003) get available versions for data source #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodben
reviewed
May 2, 2025
Comment on lines
+348
to
+351
| beforeEach(async () => { | ||
| assert(store); | ||
| await store.updatePages(moviePagesWithVersion); | ||
| }); |
There was a problem hiding this comment.
this can be beforeAll since you're only reading from the data in the tests
also add a clean up operation to remove the stuff you added to not interfere w/ other tests
There was a problem hiding this comment.
It fails with a beforeAll bc there's an afterEach in the parent describe that drops the db after each test. Keeping this as a beforeEach. I did add an afterAll to clean up
mongodben
reviewed
May 5, 2025
| @@ -29,6 +30,9 @@ export type MongoDbPageStore = DatabaseConnection & | |||
| expectedUrls: string[]; | |||
| urlTransformer?: (url: string) => string; | |||
| }): Promise<string[]>; | |||
| getDataSourceVersions(args: { | |||
| dataSources: string[]; | |||
| }): Promise<Array<SourceVersions>>; | |||
There was a problem hiding this comment.
Suggested change
| }): Promise<Array<SourceVersions>>; | |
| }): Promise<SourceVersions[]>; |
There was a problem hiding this comment.
given the new SourceVersions type, shouldn't this be a single object, not an array?
There was a problem hiding this comment.
maybe you just need to pull the first element out of the array returned by the aggregation?
There was a problem hiding this comment.
if there are multiple sources requested, or none, the result will be an array of objects (sourceNames with their version info)
mongodben
approved these changes
May 5, 2025
yakubova92
added a commit
that referenced
this pull request
May 19, 2025
* (EAI-968) ingest multiple versions (#683) * (EAI-969) query multiple versions (#693) * (EAI-1003) get available versions for data source (#696) * (EAI-922) ensure only current version on hugging face dataset (#698) * (EAI-1001) enable search by type (#703) * add sourceType to pages and embedded_content and ability to filter by it * change sourceRegex filter to sourceType filter
mongodben
pushed a commit
that referenced
this pull request
May 20, 2025
* (EAI-968) ingest multiple versions (#683) * remove snooty prefix * ingesting pages for all branches on each data source * do not ingest (and delete if already exists) pages on inactive branches * handle current version override * cleanup unused code from previous version override implementation, tests * update SnootyDataSource tests * remove override for docs current version * (EAI-969) query multiple versions (#693) * nearest neighbor search accepts filters, defaults to current version * parse filters to mdb query * (EAI-1003) get available versions for data source (#696) * get versions of a data source * get versions for multiple data sources * (EAI-922) ensure only current version on hugging face dataset (#698) * exclude old versions from dataset * add test case * fix other tests * fix return type of getDataSourceVersions - return object, not array * move QueryFilters type def to embedded content store * fix type * (EAI-1001) enable search by type (#703) * add sourceType to pages and embedded_content and ability to filter by it * test case * change sourceRegex filter to sourceType filter * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.mongodb.org/browse/EAI-1003
Changes
Notes