-
Notifications
You must be signed in to change notification settings - Fork 905
GODRIVER-2978 Automate syncing code between Go driver v1 and v2 #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Alternatively, could an existing action like https://github.com/marketplace/actions/sync-branches work as well?
etc/cherry-picker.sh
Outdated
sha=$1 | ||
base=v1 | ||
target=master | ||
dirname="/tmp/go-driver-$(openssl rand -hex 12)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: Consider using mktemp -d
instead, which honors the temp dir on different OSes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Updated to use our own action, since github.com/marketplace/actions/sync-branches is unmaintained, and this allows us to use the same script locally when needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
…v2 (mongodb#1391)" This reverts commit 8d10a9e.
GODRIVER-2978
Summary
Help automate syncing between the v1 branch and master, which is targeting v1.
Background & Motivation
Help make the v2 transition smoother.