Skip to content

GODRIVER-2117 - Check clientSession is not nil inside executeTestRunnerOperation #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2023
Merged

GODRIVER-2117 - Check clientSession is not nil inside executeTestRunnerOperation #1457

merged 1 commit into from
Nov 8, 2023

Conversation

kumarlokesh
Copy link
Contributor

@kumarlokesh kumarlokesh commented Nov 5, 2023 •
edited
Loading

GODRIVER-2117

Summary

  • In method executeTestRunnerOperation, check clientSession for nullability
    where clientSession is required.
  • Return errors to the caller - this makes error handling consistent
    across executeTestRunnerOperation.

Background & Motivation

@kumarlokesh kumarlokesh requested a review from a team as a code owner November 5, 2023 18:35
@kumarlokesh kumarlokesh requested review from prestonvasquez and removed request for a team November 5, 2023 18:35
prestonvasquez
prestonvasquez requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@prestonvasquez prestonvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kumarlokesh , thank you for the contribution 👍

@kumarlokesh
Copy link
Contributor Author

Hi @kumarlokesh , thank you for the contribution 👍

Thanks @prestonvasquez for the review and sharing feedback!
I've addressed previous comments.

@kumarlokesh kumarlokesh changed the title GODRIVER-2117 - Assert clientSession is not nil inside executeTestRunnerOperation GODRIVER-2117 - Check clientSession is not nil inside executeTestRunnerOperation Nov 7, 2023
@mongodb-drivers-pr-bot mongodb-drivers-pr-bot
Copy link
Contributor

API Change Report

No changes found!

prestonvasquez
prestonvasquez approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@prestonvasquez prestonvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 merged commit fd1ca35 into mongodb:v1 Nov 8, 2023
blink1073 pushed a commit to blink1073/mongo-go-driver that referenced this pull request Nov 8, 2023
@kumarlokesh @blink1073
GODRIVER-2117 - Check clientSession is not nil inside executeTestRunn…
67a5625 
…erOperation (mongodb#1457)

(cherry picked from commit fd1ca35)
@blink1073 blink1073 mentioned this pull request Nov 8, 2023
Merged
@kumarlokesh kumarlokesh deleted the GODRIVER-2117 branch November 8, 2023 19:13
prestonvasquez pushed a commit to prestonvasquez/mongo-go-driver that referenced this pull request Nov 9, 2023
@kumarlokesh @prestonvasquez
GODRIVER-2117 - Check clientSession is not nil inside executeTestRunn…
98bda43 
…erOperation (mongodb#1457)
prestonvasquez pushed a commit to prestonvasquez/mongo-go-driver that referenced this pull request Nov 9, 2023
@kumarlokesh @prestonvasquez
GODRIVER-2117 - Check clientSession is not nil inside executeTestRunn…
ca18de0 
…erOperation (mongodb#1457)
This was referenced Mar 4, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvasquez prestonvasquez prestonvasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumarlokesh @prestonvasquez @blink1073