fix README error handling of FindOne #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
requested changes
Apr 22, 2021
Contributor
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
Thank you for the catch and contribution @c3b5aw!
kevinAlbs
changed the title
Contributor
Author
|
Rewrote block as excepted and added one space where it was missing in upper block so every examples fit 4 spaces indent. |
kevinAlbs
approved these changes
May 4, 2021
Contributor
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM. Thank you again for the contribution @c3b5aw!
iwysiu
approved these changes
May 4, 2021
faem
pushed a commit
to kubedb/mongo-go-driver
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original example goes log.Fatal if your query return something different than "ErrNoDocuments" but, we want to go Fatal if you have an error which is unhandled.
Otherwise, we can never process query result after error check.