Skip to content

Commit a0906e7

Browse files
committed
Remove getCluster method (#1245)
from the following internal interfaces: * ClusterAwareReadWriteBinding * AsyncClusterAwareReadWriteBinding The interfaces remain as they have picket up a second method. JAVA-5217
1 parent f8e6b82 commit a0906e7

File tree

6 files changed

+2
-31
lines changed

6 files changed

+2
-31
lines changed

driver-core/src/main/com/mongodb/internal/binding/AsyncClusterAwareReadWriteBinding.java

-2
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,11 @@
1818

1919
import com.mongodb.ServerAddress;
2020
import com.mongodb.internal.async.SingleResultCallback;
21-
import com.mongodb.internal.connection.Cluster;
2221

2322
/**
2423
* <p>This class is not part of the public API and may be removed or changed at any time</p>
2524
*/
2625
public interface AsyncClusterAwareReadWriteBinding extends AsyncReadWriteBinding {
27-
Cluster getCluster();
2826

2927
/**
3028
* Returns a connection source to the specified server

driver-core/src/main/com/mongodb/internal/binding/AsyncClusterBinding.java

-5
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,6 @@ public AsyncClusterAwareReadWriteBinding retain() {
8080
return this;
8181
}
8282

83-
@Override
84-
public Cluster getCluster() {
85-
return cluster;
86-
}
87-
8883
@Override
8984
public ReadPreference getReadPreference() {
9085
return readPreference;

driver-core/src/main/com/mongodb/internal/binding/ClusterAwareReadWriteBinding.java

-2
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,11 @@
1717
package com.mongodb.internal.binding;
1818

1919
import com.mongodb.ServerAddress;
20-
import com.mongodb.internal.connection.Cluster;
2120

2221
/**
2322
* This interface is not part of the public API and may be removed or changed at any time.
2423
*/
2524
public interface ClusterAwareReadWriteBinding extends ReadWriteBinding {
26-
Cluster getCluster();
2725

2826
/**
2927
* Returns a connection source to the specified server address.

driver-core/src/main/com/mongodb/internal/binding/ClusterBinding.java

+1-9
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222
import com.mongodb.ServerAddress;
2323
import com.mongodb.ServerApi;
2424
import com.mongodb.connection.ClusterConnectionMode;
25-
import com.mongodb.internal.connection.OperationContext;
2625
import com.mongodb.connection.ServerDescription;
2726
import com.mongodb.internal.connection.Cluster;
2827
import com.mongodb.internal.connection.Connection;
28+
import com.mongodb.internal.connection.OperationContext;
2929
import com.mongodb.internal.connection.ReadConcernAwareNoOpSessionContext;
3030
import com.mongodb.internal.connection.Server;
3131
import com.mongodb.internal.connection.ServerTuple;
@@ -71,14 +71,6 @@ public ClusterBinding(final Cluster cluster, final ReadPreference readPreference
7171
operationContext = new OperationContext();
7272
}
7373

74-
/**
75-
* Return the cluster.
76-
* @return the cluster
77-
*/
78-
public Cluster getCluster() {
79-
return cluster;
80-
}
81-
8274
@Override
8375
public ReadWriteBinding retain() {
8476
super.retain();

driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/crypt/CryptBinding.java

-6
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import com.mongodb.internal.binding.AsyncClusterAwareReadWriteBinding;
2626
import com.mongodb.internal.binding.AsyncConnectionSource;
2727
import com.mongodb.internal.connection.AsyncConnection;
28-
import com.mongodb.internal.connection.Cluster;
2928
import com.mongodb.internal.connection.OperationContext;
3029
import com.mongodb.internal.session.SessionContext;
3130
import com.mongodb.lang.Nullable;
@@ -132,11 +131,6 @@ public int release() {
132131
return wrapped.release();
133132
}
134133

135-
@Override
136-
public Cluster getCluster() {
137-
return wrapped.getCluster();
138-
}
139-
140134
private class CryptConnectionSource implements AsyncConnectionSource {
141135
private final AsyncConnectionSource wrapped;
142136

driver-sync/src/main/com/mongodb/client/internal/CryptBinding.java

+1-7
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,12 @@
2020
import com.mongodb.RequestContext;
2121
import com.mongodb.ServerAddress;
2222
import com.mongodb.ServerApi;
23-
import com.mongodb.internal.connection.OperationContext;
2423
import com.mongodb.connection.ServerDescription;
2524
import com.mongodb.internal.binding.ClusterAwareReadWriteBinding;
2625
import com.mongodb.internal.binding.ConnectionSource;
2726
import com.mongodb.internal.binding.ReadWriteBinding;
28-
import com.mongodb.internal.connection.Cluster;
2927
import com.mongodb.internal.connection.Connection;
28+
import com.mongodb.internal.connection.OperationContext;
3029
import com.mongodb.internal.session.SessionContext;
3130
import com.mongodb.lang.Nullable;
3231

@@ -101,11 +100,6 @@ public int release() {
101100
return wrapped.release();
102101
}
103102

104-
@Override
105-
public Cluster getCluster() {
106-
return wrapped.getCluster();
107-
}
108-
109103
private class CryptConnectionSource implements ConnectionSource {
110104
private final ConnectionSource wrapped;
111105

0 commit comments

Comments
 (0)