Skip to content

Remove getCluster method #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Remove getCluster method #1245

merged 1 commit into from
Nov 7, 2023

Conversation

jyemin
Copy link
Collaborator

@jyemin jyemin commented Nov 3, 2023

from the following internal interfaces:

  • ClusterAwareReadWriteBinding
  • AsyncClusterAwareReadWriteBinding

The interfaces remain, as they have picket up a second method. The existing interface names arguably still make sense since implementations have to be "cluster-aware" in order to implement the remaining method.

JAVA-5217

from the following internal interfaces:

* ClusterAwareReadWriteBinding
* AsyncClusterAwareReadWriteBinding

The interfaces remain as they have picket up a second method.

JAVA-5217
@jyemin jyemin self-assigned this Nov 3, 2023
@jyemin jyemin requested a review from rozza November 6, 2023 16:38
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice and simple

@jyemin jyemin merged commit 3eaaff3 into mongodb:5.x Nov 7, 2023
@jyemin jyemin deleted the j5217 branch November 7, 2023 12:44
jyemin added a commit that referenced this pull request Dec 4, 2023
from the following internal interfaces:

* ClusterAwareReadWriteBinding
* AsyncClusterAwareReadWriteBinding

The interfaces remain as they have picket up a second method.

JAVA-5217
jyemin added a commit that referenced this pull request Dec 5, 2023
from the following internal interfaces:

* ClusterAwareReadWriteBinding
* AsyncClusterAwareReadWriteBinding

The interfaces remain as they have picket up a second method.

JAVA-5217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants