Skip to content

PYTHON-4613 - Fix Eventlet tests failing with Runner.run() cannot be … #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 12, 2024
Merged

PYTHON-4613 - Fix Eventlet tests failing with Runner.run() cannot be … #1780

merged 4 commits into from
Aug 12, 2024

Conversation

NoahStapp
Copy link
Contributor

@NoahStapp NoahStapp commented Aug 8, 2024 •
edited by ShaneHarvey
Loading

…called from a running event loop

PYTHON-4613

@NoahStapp NoahStapp requested a review from ShaneHarvey August 8, 2024 20:57
blink1073
blink1073 previously approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ShaneHarvey
ShaneHarvey requested changes Aug 8, 2024
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The eventlet tests are still failing to run async tests: https://spruce.mongodb.com/task/mongo_python_driver_tests_python_version_green_framework_rhel8__platform~rhel8_auth_ssl~auth_ssl_python_version~3.10_green_framework~eventlet_test_rapid_standalone_patch_b14420a9df321714a06ddae1a907a04846ebca20_66b538ac47c9db0007a185ff_24_08_08_21_29_19/tests?execution=0&sortBy=STATUS&sortDir=ASC

@NoahStapp
Copy link
Contributor Author

The eventlet tests are still failing to run async tests: spruce.mongodb.com/task/mongo_python_driver_tests_python_version_green_framework_rhel8__platformrhel8_auth_sslauth_ssl_python_version3.10_green_frameworkeventlet_test_rapid_standalone_patch_b14420a9df321714a06ddae1a907a04846ebca20_66b538ac47c9db0007a185ff_24_08_08_21_29_19/tests?execution=0&sortBy=STATUS&sortDir=ASC

Fixed with the latest commit.

@NoahStapp NoahStapp requested a review from ShaneHarvey August 9, 2024 17:42
@ShaneHarvey
Copy link
Member

@NoahStapp the eventlet tests are still failing.

@NoahStapp
Copy link
Contributor Author

@NoahStapp the eventlet tests are still failing.

Fixed.

@ShaneHarvey ShaneHarvey merged commit a232b65 into mongodb:master Aug 12, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@blink1073 blink1073 blink1073 left review comments

@caseyclements caseyclements Awaiting requested review from caseyclements

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoahStapp @ShaneHarvey @blink1073