-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5292 - Debug logs should only print on failed tests #2296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
pymongo/logger.py
Outdated
@@ -15,6 +15,7 @@ | |||
|
|||
import enum | |||
import logging | |||
import logging.handlers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this import used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Note: this PR does not turn on debug logs by default in our Evergreen tests. That will be tracked in a separate, follow-up ticket.