RUST-754 Accept impl Borrow<T> in insert and replace methods #331
Conversation
| @@ -541,7 +541,7 @@ async fn empty_insert() { | |||
| .database(function_name!()) | |||
| .collection::<Document>(function_name!()); | |||
| match coll | |||
| .insert_many(Vec::new(), None) | |||
| .insert_many(Vec::<Document>::new(), None) | |||
There was a problem hiding this comment.
In certain cases, this will make type inference more difficult and require the usage of type arguments, such as in this case. I think this is worth it over taking in just &T though, which rules out owned values and other smart-pointer types from being passed in (e.g. Arc, Box). I think in most cases users won't be relying on the concrete type in these methods and the annotations won't be necessary.
There was a problem hiding this comment.
Yeah this seems like a fairly similar situation to the one I outlined during the Serde work where the concrete type is needed in the method parameter to assign types to generic function calls like Vec::new. Our consensus was that a situation like that would be quite rare, and since we're doing a 2.0 I think it's fine to break this/require these types in the future (especially given that the only place this shows up within our testing is on this call which results in an error anyway).
| @@ -541,7 +541,7 @@ async fn empty_insert() { | |||
| .database(function_name!()) | |||
| .collection::<Document>(function_name!()); | |||
| match coll | |||
| .insert_many(Vec::new(), None) | |||
| .insert_many(Vec::<Document>::new(), None) | |||
There was a problem hiding this comment.
Yeah this seems like a fairly similar situation to the one I outlined during the Serde work where the concrete type is needed in the method parameter to assign types to generic function calls like Vec::new. Our consensus was that a situation like that would be quite rare, and since we're doing a 2.0 I think it's fine to break this/require these types in the future (especially given that the only place this shows up within our testing is on this call which results in an error anyway).
RUST-754
This PR updates the various insert and replace methods to accept
impl Borrow<T>, which means that both owned values and values that can be converted into references can be accepted in these methods.In a related change, the trait requirements on
Tin the sync driver were relaxed now that tokio and async-std's blocking functions no longer require it.