Skip to content

KUBE-266: Update go SDK - #3448

Open
helderjs wants to merge 6 commits into
mainfrom
KUBE-266-update-sdk
Open

KUBE-266: Update go SDK#3448
helderjs wants to merge 6 commits into
mainfrom
KUBE-266-update-sdk

Conversation

@helderjs

Copy link
Copy Markdown
Collaborator

Summary

Proof of Work

CI Pass

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

helderjs added 6 commits July 29, 2026 13:00
Signed-off-by: Helder Santana <helder.santana@mongodb.com>
Signed-off-by: Helder Santana <helder.santana@mongodb.com>
Signed-off-by: Helder Santana <helder.santana@mongodb.com>
Signed-off-by: Helder Santana <helder.santana@mongodb.com>
Signed-off-by: Helder Santana <helder.santana@mongodb.com>
Signed-off-by: Helder Santana <helder.santana@mongodb.com>
@helderjs
helderjs requested a review from a team as a code owner July 29, 2026 12:20

@josvazg josvazg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: No breaking changes in prod

Final breaking-change check — result: no breaking changes found
Scanned production surface: api/v1/, generated/v1/ (stable, non-experimental), internal/generated/crds/crds.yaml, internal/generated/controller/** (non-experimental), and prod controller/translation Go files. Excluded tools/clean/, internal/nextapi/ (experimental), and tests as instructed.
Renames: none beyond the already-approved Api→API SDK casing convention and the pre-existing EffectiveReplicationSpecs rename (confirmed already on origin/main before this branch).
Removals:

  • internal/generated/crds/crds.yaml — only creationTimestamp: null dropped from 5 CRDs' metadata (controller-gen boilerplate, no schema impact) and x-atlas-sdk-version value bump. No properties, type, required, or enum entries removed.
  • generated/v1/group.go:76 — doc-comment-only removal: "This setting cannot be updated after project creation." dropped from WithDefaultAlertsSettings field docs. Cosmetic, no code/schema change, no +kubebuilder marker touched — not a wire-level break.
    Behavior changes:
  • internal/generated/controller/databaseuser/handler.go:153 — Watches() registration order swapped: Group watch now registered before Secret watch (was Secret then Group). Functionally equivalent — controller-runtime doesn't guarantee/depend on watch registration order for reconcile correctness, both watches still fire independently. Flagging for your judgment, but not blocking.

Nothing else in the CRD YAML, generated types, or generated/prod controllers constitutes a rename, removal, or behavior change to the production API surface. Safe to approve as far as breaking-change risk on prod-facing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants