SQL-3167: wasm process collection - #150
Merged
nicholascioli merged 19 commits intoJun 3, 2026
Merged
Conversation
nicholascioli
force-pushed
the
wasm-process-collection
branch
2 times, most recently
from
May 29, 2026 16:58
f4be03b to
c7bb42b
Compare
nicholascioli
marked this pull request as ready for review
May 29, 2026 17:00
Collaborator
Author
|
The PR has been rebased and is ready for review. |
bucaojit
approved these changes
May 29, 2026
bucaojit
left a comment
bucaojit
left a comment
Member
There was a problem hiding this comment.
Looks good, I had one comment regarding the integration test to consider.
jchemburkar
requested changes
Jun 1, 2026
jchemburkar
left a comment
jchemburkar
left a comment
Collaborator
There was a problem hiding this comment.
Great job with getting this to compile + adding the ts testing scaffolding! I just have some thoughts + questions on what exactly we should be testing
nicholascioli
force-pushed
the
wasm-process-collection
branch
from
June 3, 2026 15:11
0409ea3 to
b336e66
Compare
Collaborator
Author
|
I've rebased against jchemburkar#5 to pull in changes needed to build. Once that gets merged, I'll rebase again. |
jchemburkar
approved these changes
Jun 3, 2026
jchemburkar
left a comment
jchemburkar
left a comment
Collaborator
There was a problem hiding this comment.
lgtm. have one more test case I think we could add. might be worth having claude do one final dead code / style pass for the JS code to make sure there's no loose ends. but no need to retag once that's all set 😁 !
This commit adds a utility method for linearly deriving a schema for a collection by splitting it into partitions and processing them one at a time.
This commit adds an integration test for verifying that a node context can still derive schemas for a collection. Note that this requires running the following command in the `schema_manager_library` folder to generate the needed files. ```sh wasm-pack build --release --no-default-features --features wasm ```
Co-authored-by: Oliver Bucaojit <oliver.bucaojit@mongodb.com>
Co-authored-by: Jonathan Chemburkar <jonathan.chemburkar@mongodb.com>
Co-authored-by: Jonathan Chemburkar <jonathan.chemburkar@mongodb.com>
Co-authored-by: Jonathan Chemburkar <jonathan.chemburkar@mongodb.com>
nicholascioli
force-pushed
the
wasm-process-collection
branch
from
June 3, 2026 19:34
8fe6cab to
4b8ff6b
Compare
nicholascioli
enabled auto-merge
June 3, 2026 19:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a utility method for deriving a collection's schema linearly over its partitions. This should allow for single-threaded consumers to easily derive a schema for a collection without worrying about how to best split up the partitions or any other internal details.
If a consumer wishes to be more performant in how it processes the collection, it can always use the lower-level
derive_schema_for_partitionto do so.Also, this PR is dependent on #148, so please review only the commits starting at "SQL-3167" and beyond. This PR will be rebased once the other PR is merged.