This repository was archived by the owner on Jan 5, 2023. It is now read-only.
TIG-1956: Add openapi support #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zamj
commented
Oct 1, 2019
| @@ -1,4 +1,4 @@ | |||
| black==19.3b0 | |||
| gunicorn==19.9.0 | |||
| pytest-flake8==1.0.4 | |||
| pytest==4.2.1 | |||
| pytest==5.2.0 | |||
There was a problem hiding this comment.
Was facing an issue where pytest would fail to run. Looks like it's linked to this issue: pytest-dev/pytest#3280
The new version is the latest released.
Logs are below from evergreen task
[2019/10/01 12:17:22.423] File "/data/mci/dd436d719c53531abd0929e7d98004f2/src/venv/bin/pytest", line 10, in <module>
[2019/10/01 12:17:22.423] sys.exit(main())
[2019/10/01 12:17:22.423] File "/data/mci/dd436d719c53531abd0929e7d98004f2/src/venv/lib/python3.7/site-packages/_pytest/config/__init__.py", line 61, in main
[2019/10/01 12:17:22.423] config = _prepareconfig(args, plugins)
[2019/10/01 12:17:22.423] File "/data/mci/dd436d719c53531abd0929e7d98004f2/src/venv/lib/python3.7/site-packages/_pytest/config/__init__.py", line 182, in _prepareconfig
[2019/10/01 12:17:22.423] config = get_config()
[2019/10/01 12:17:22.423] File "/data/mci/dd436d719c53531abd0929e7d98004f2/src/venv/lib/python3.7/site-packages/_pytest/config/__init__.py", line 156, in get_config
[2019/10/01 12:17:22.423] pluginmanager.import_plugin(spec)
[2019/10/01 12:17:22.423] File "/data/mci/dd436d719c53531abd0929e7d98004f2/src/venv/lib/python3.7/site-packages/_pytest/config/__init__.py", line 533, in import_plugin
[2019/10/01 12:17:22.423] __import__(importspec)
[2019/10/01 12:17:22.423] File "/data/mci/dd436d719c53531abd0929e7d98004f2/src/venv/lib/python3.7/site-packages/_pytest/tmpdir.py", line 25, in <module>
[2019/10/01 12:17:22.423] class TempPathFactory(object):
[2019/10/01 12:17:22.423] File "/data/mci/dd436d719c53531abd0929e7d98004f2/src/venv/lib/python3.7/site-packages/_pytest/tmpdir.py", line 35, in TempPathFactory
[2019/10/01 12:17:22.423] lambda p: Path(os.path.abspath(six.text_type(p)))
[2019/10/01 12:17:22.423] TypeError: attrib() got an unexpected keyword argument 'convert'```
lydiastepanek
approved these changes
Oct 1, 2019
dbradf
reviewed
Oct 1, 2019
| from flask_restplus import Api, Resource, fields | ||
|
|
||
|
|
||
| def add_health_endpoints(api: Api): |
There was a problem hiding this comment.
Could you add a docstring to this function?
| health_model = ns.model("HealthCheckResponse", {"online": fields.Boolean}) | ||
|
|
||
| @ns.route("") | ||
| class Health(Resource): |
There was a problem hiding this comment.
Could you add a docstring to this class?
dbradf
approved these changes
Oct 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.