Output container_definitions is not a list if register_task_definition is set to false

[akikoskinen]

According to container_definitions output variable documentation:

A list of container definitions in JSON format that describe the different containers that make up your task

But if one sets the register_task_definition input variable to "false" (in order to use this module only as a container definitions JSON generator), the container_definitions output is not a list, but a JSON object, representing a single container definition. I think it's a bug to change the output variables type based on a seemingly unrelated input variable.

The place where this happens in the code is here.

[jasonwalsh]

Hi @akikoskinen 👋

You might want to refer to #29 for more insight. There is a reason the container definitions object is not a list if register_task_definition is set to false.

Please let me know if #29 (comment) answers your question.

[akikoskinen]

I understand the use cases now. But having an input variable called register_task_definition also control the feature output_json_object_instead_of_array is very unexpected. Perhaps there should be a dedicated input variable for this latter feature? Or at the very least the documentation should state this unexpected behavior, possibly with some heavily emphasized font.