Groundwork for the coverage tool integration

main/src/addins/MacPlatform/MacPlatform.cs

@@ -289,6 +289,8 @@ static void RegisterUncaughtExceptionHandler ()
 			NSSetUncaughtExceptionHandler (uncaughtHandler);
 		}
 
+		internal static List<IDisposable> AllObservers { get; } = new List<IDisposable> ();
+
 		public override Xwt.Toolkit LoadNativeToolkit ()
 		{
 			var loaded = NativeToolkitHelper.LoadCocoa ();
@@ -307,6 +309,10 @@ public override Xwt.Toolkit LoadNativeToolkit ()
 			var appDelegate = NSApplication.SharedApplication.Delegate as Xwt.Mac.AppDelegate;
 			if (appDelegate != null) {
 				appDelegate.Terminating += async (object o, TerminationEventArgs e) => {
+					foreach (var observer in AllObservers)
+						observer.Dispose ();
+					AllObservers.Clear ();
+
 					if (MonoDevelop.Ide.IdeApp.IsRunning) {
 						// If GLib the mainloop is still running that means NSApplication.Terminate() was called
 						// before Gtk.Application.Quit(). Cancel Cocoa termination and exit the mainloop.
@@ -319,14 +325,17 @@ public override Xwt.Toolkit LoadNativeToolkit ()
 						e.Reply = NSApplicationTerminateReply.Now;
 					}
 				};
+
+				// TODO: only attach this if coverage profiler is on
+				appDelegate.Terminate += () => Environment.Exit (0);
 				appDelegate.ShowDockMenu += AppDelegate_ShowDockMenu;
 			}
 
 			// Listen to the AtkCocoa notification for the presence of VoiceOver
 			SwizzleNSApplication ();
 
 			var nc = NSNotificationCenter.DefaultCenter;
-			notificationObservers.Add (nc.AddObserver ((NSString)"AtkCocoaAccessibilityEnabled", (NSNotification) => {
+			AllObservers.Add (nc.AddObserver ((NSString)"AtkCocoaAccessibilityEnabled", (NSNotification) => {
 				LoggingService.LogInfo ($"VoiceOver on {IdeTheme.AccessibilityEnabled}");
 				if (!IdeTheme.AccessibilityEnabled) {
 					ShowVoiceOverNotice ();
@@ -582,15 +591,15 @@ void InitApp (CommandManager commandManager)
 
 			if (MacSystemInformation.OsVersion >= MacSystemInformation.Mojave) {
 				IdeTheme.HighContrastThemeEnabled = GetIsHighContrastActive ();
-				notificationObservers.Add (NSApplication.SharedApplication.AddObserver ("effectiveAppearance", NSKeyValueObservingOptions.New, notif =>
+				AllObservers.Add (NSApplication.SharedApplication.AddObserver ("effectiveAppearance", NSKeyValueObservingOptions.New, notif =>
 					Core.Runtime.RunInMainThread (() => {
 						IdeTheme.HighContrastThemeEnabled = GetIsHighContrastActive ();
 						PatchGtkTheme ();
 					})
 				));
 			} else {
 				IdeTheme.HighContrastThemeEnabled = false;
-				notificationObservers.Add (NSNotificationCenter.DefaultCenter.AddObserver (NSCell.ControlTintChangedNotification, notif => Core.Runtime.RunInMainThread (
+				AllObservers.Add (NSNotificationCenter.DefaultCenter.AddObserver (NSCell.ControlTintChangedNotification, notif => Core.Runtime.RunInMainThread (
 					delegate {
 						Styles.LoadStyle ();
 						PatchGtkTheme ();

main/src/addins/MacPlatform/MainToolbar/AwesomeBar.cs

@@ -144,7 +144,7 @@ public override void ViewDidMoveToWindow ()
 		public override void ViewWillMoveToSuperview (NSView newSuperview)
 		{
 			if (Superview != null && superviewFrameChangeObserver != null) {
-				NSNotificationCenter.DefaultCenter.RemoveObserver (superviewFrameChangeObserver);
+				superviewFrameChangeObserver.Dispose ();
 				superviewFrameChangeObserver = null;
 
 				Superview.PostsFrameChangedNotifications = false;

main/src/addins/MacPlatform/MainToolbar/MainToolbar.cs

@@ -192,12 +192,12 @@ public MainToolbar (Gtk.Window window)
 						item.MinSize = size;
 					}
 				});
-				NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.DidResizeNotification, resizeAction, nswin);
-				NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.DidEndLiveResizeNotification, resizeAction, nswin);
+				MacPlatformService.AllObservers.Add (NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.DidResizeNotification, resizeAction, nswin));
+				MacPlatformService.AllObservers.Add (NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.DidEndLiveResizeNotification, resizeAction, nswin));
 			}
 
-			NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.WillEnterFullScreenNotification, (note) => IsFullscreen = true, nswin);
-			NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.WillExitFullScreenNotification, (note) => IsFullscreen = false, nswin);
+			MacPlatformService.AllObservers.Add (NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.WillEnterFullScreenNotification, (note) => IsFullscreen = true, nswin));
+			MacPlatformService.AllObservers.Add (NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.WillExitFullScreenNotification, (note) => IsFullscreen = false, nswin));
 		}
 
 		internal void Initialize ()

main/src/addins/MacPlatform/MainToolbar/SearchBar.cs

@@ -243,7 +243,7 @@ void UpdateLayout ()
 
 		void Initialize ()
 		{
-			NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.DidResignKeyNotification, notification => Runtime.RunInMainThread (() => {
+			MacPlatformService.AllObservers.Add (NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.DidResignKeyNotification, notification => Runtime.RunInMainThread (() => {
 				var other = (NSWindow)notification.Object;
 
 				if (notification.Object == Window) {
@@ -252,16 +252,16 @@ void Initialize ()
 							LostFocus (this, null);
 					}
 				}
-			}));
-			NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.DidResizeNotification, notification => Runtime.RunInMainThread (() => {
+			})));
+			MacPlatformService.AllObservers.Add (NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.DidResizeNotification, notification => Runtime.RunInMainThread (() => {
 				var other = (NSWindow)notification.Object;
 				if (notification.Object == Window) {
 					if (IsFirstResponderOfWindow (Window)) {
 						if (LostFocus != null)
 							LostFocus (this, null);
 					}
 				}
-			}));
+			})));
 		}
 
 		bool IsFirstResponderOfWindow (NSWindow window)

main/src/addins/MacPlatform/MainToolbar/SelectorView.cs

@@ -788,8 +788,8 @@ public override void ViewDidMoveToWindow ()
 			{
 				base.ViewDidMoveToWindow ();
 
-				NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.DidChangeBackingPropertiesNotification,
-				                                                notification => Runtime.RunInMainThread ((Action) RealignTexts));
+				MacPlatformService.AllObservers.Add (NSNotificationCenter.DefaultCenter.AddObserver (NSWindow.DidChangeBackingPropertiesNotification,
+				                                                notification => Runtime.RunInMainThread ((Action) RealignTexts)));
 				RealignTexts ();
 			}
 

main/src/addins/MacPlatform/ScreenMonitor.cs

@@ -56,9 +56,9 @@ public static class ScreenMonitor
 		static ScreenMonitor ()
 		{
 			screenToGdk = UpdateScreenLayout ();
-			NSNotificationCenter.DefaultCenter.AddObserver (NSApplication.DidChangeScreenParametersNotification, (obj) => {
+			MacPlatformService.AllObservers.Add (NSNotificationCenter.DefaultCenter.AddObserver (NSApplication.DidChangeScreenParametersNotification, (obj) => {
 				screenToGdk = UpdateScreenLayout ();
-			});
+			}));
 		}
 
 		public static CGPoint GdkPointForNSScreen (NSScreen screen)