-
Notifications
You must be signed in to change notification settings - Fork 159
add arc intensity #1868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add arc intensity #1868
Conversation
|
Ok, this is failing the CI because the testing image doesn't have an updated libmonome. Which brings me to another point--- the update would be easier-ish if we just included libmonome as a submodule of norns instead of expecting it to be present system-wide (serialosc does this). I would welcome any strong opinions about this. @artfwo @Dewb ps. this PR tested with hardware, working well. |
|
it shouldn't be a big problem, libmonome has a wscript that can be included from norns wscript to build a (static) libmonome to link to. but given that libmonome is updated not so frequently, how likely we're going to need to change that once the image is up to date? that said, there may be other reasons to include it as submodule, e.g. dropping a dependency on a package, but not sure if that's still relevant. is libmonome built from source for the image or installed from a .deb? |
|
For now, changing the version number here should be sufficient to satisfy CI: Line 40 in d5bdf1d
This is the CI working as intended by failing until the new dependency is documented. Hooray! The medium term issue IMO is that the efforts to update CI, developer environment instructions (if people aren’t using the CI image as a devcontainer), and the release image are still three separate things. Moving the libmonome build from Dockerfile to wscript avoids that issue for one dependency, but I think iterating towards a general solution to the bigger issue would pay off across the board. |
|
Ah @robbielyman and I have one last step to perform to auto-update the image when the Dockerfile changes. |
|
thanks for the tip! corrected the Dockerfile but it seems the CI container needs to be recompiled. libmonome on the actual disk image is manually compiled from source. the entire process is very by-hand. https://github.com/monome/norns-image/blob/main/build-dev-image.md?plain=1#L88 for the next update I'll simply include the source tree and add that step to modify the disk image. |
A possible approach for this last step is described in #1853:
|
|
The compile check Action will now use the Dockerfile in the PR to run the compilation step, and results will be cached in the container registry. Hooray! |
|
thank you @Dewb ! |
note this requires a libmonome update (which I can bundle in the next norns update) and also arc firmware update (to be released formally).
there are no plans to add intensity to older edition arcs as they are already super dim.