localization #2604
localization #2604
Conversation
| { | ||
| trigger: "manual", | ||
| label: "@effect.name", | ||
| label: game.i18n.localize("WFRP4E.ConditionName.Bleeding"), |
There was a problem hiding this comment.
I'm not sure why this is necessary if the effect name itself is localized?
There was a problem hiding this comment.
i noticed in some cases, that the effect itself was just "@effect.name". I guess it doesn't matter that much, since those are mostly hidden but i thought about keeping it consistent.
If that's a problem, i will revert
| { | ||
| trigger: "dialog", | ||
| label: "Penalty to all Tests (@effect.name)", | ||
| label: game.i18n.format("WFRP4E.ConditionEffects.PenaltyToAllTests", {effect: game.i18n.localize("WFRP4E.ConditionName.Stunned")}), |
There was a problem hiding this comment.
I feel like localizing script labels is a but much, most of them are hardly seen, and if it's necessary could just be replaced by the translation module?
There was a problem hiding this comment.
this would require replacement of whole object in the config, which i wanted to avoid in this case. And since there weren't so many - I wanted to keep it simple. but again, its your call - i can remove it.
2 participants
More localization strings, cleanup and order of en.json, for easier translations/change tracking.