fix: stop endless reconcile loop 94#95
Closed
henninge wants to merge 2 commits into
Closed
Conversation
henninge
changed the title
Contributor
Author
|
I realized that the actual fix in this is to write a constant value in I would change this to remove |
Owner
|
I think this was fixed in #97, let me know if you have any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: This is a first draft of a fix for the endless reconcile loop.
The actual fix should put the compare functionality in a predicate for an event filter.
Which issue this PR fixes: fixes #94
Notes:
Still WIP but I needed HS to STFU.