Skip to content

Adds smoke-test suite#1409

Merged
crystalin merged 6 commits into
masterfrom
crystalin-smoke-tests
Apr 15, 2022
Merged

Adds smoke-test suite#1409
crystalin merged 6 commits into
masterfrom
crystalin-smoke-tests

Conversation

@crystalin

Copy link
Copy Markdown
Collaborator

Adds the structure to support smoke tests and an initial test.

Smoke test in that context mean tests that are executed against a running blockchain (Moonbeam, Moonriver, or internal/local) without sending any transaction (to avoid modifying the state). In general you can consider those as tests to verify the consistency of the blockchain data.

@crystalin crystalin added A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit D2-notlive PR doesn't change runtime code (so can't be audited) and removed D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Apr 13, 2022
Comment on lines +18 to +19
// It takes time to load all the accounts.
this.timeout(600000);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we have 500k+ accounts on Moonriver

@notlesh notlesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like this idea.

Here are some sanity checks that come to mind:

  • Ensuring that treasury account exists / has > 0 balance
  • Ensure that fee mutiplier (pallet_transaction_payment/EIP1559) is within a sane range
  • Ensure past migrations are properly known
  • Ensure author eligibility
  • Check any key rotation restrictions
  • State of sudo key
  • All asset-manager assets have exactly one AssetTypeUnitsPerSecond entry
  • Other XCM state (e.g. we always have xcKSM properly configured)

@crystalin crystalin force-pushed the crystalin-smoke-tests branch from 30470b3 to 05bc709 Compare April 14, 2022 22:51
@crystalin crystalin merged commit cd88f7d into master Apr 15, 2022
@crystalin crystalin deleted the crystalin-smoke-tests branch April 15, 2022 12:11
@crystalin crystalin restored the crystalin-smoke-tests branch July 7, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants