Skip to content

Conversation

@4meta5
Copy link
Contributor

@4meta5 4meta5 commented May 27, 2022

Makes the set_keys precompile interface consistent with the extrinsic changes in #1535 . Thanks for reporting @eshaben !

⚠️ Changes set_keys precompile interface from set_keys(bytes32,bytes32) to set_keys(bytes). As a result, the precompile selector changes. Tests do not require any changes.

@4meta5 4meta5 added A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D2-breaksapi This PR changes public API; next release should be major. D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels May 27, 2022
@4meta5 4meta5 added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes A8-mergeoncegreen Pull request is reviewed well. and removed B0-silent Changes should not be mentioned in any release notes A0-pleasereview Pull request needs code review. labels May 27, 2022
@4meta5 4meta5 merged commit da03fdc into master May 27, 2022
@4meta5 4meta5 deleted the amar-fix-set-keys-precompile-interface branch May 27, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A8-mergeoncegreen Pull request is reviewed well. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D2-breaksapi This PR changes public API; next release should be major. D3-trivial PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants