Skip to content

Conversation

@girazoki
Copy link
Collaborator

What does it do?

Fixes author-inherent benchmark, since runtime-benchmark features was missing for parachain-system

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@girazoki girazoki requested a review from notlesh July 18, 2022 10:54
@girazoki girazoki added the D3-trivial PR contains trivial changes in a runtime directory that do not require an audit label Jul 18, 2022
@girazoki girazoki changed the title Girazoki fix author inherent benchmark fix author inherent benchmark Jul 18, 2022
@girazoki girazoki added the B0-silent Changes should not be mentioned in any release notes label Jul 18, 2022
@girazoki girazoki force-pushed the girazoki-fix-author-inherent-benchmark branch from 3401e32 to a6d5cd3 Compare July 18, 2022 11:38
Copy link
Contributor

@notlesh notlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@girazoki girazoki merged commit 0c7d6c7 into master Jul 18, 2022
@girazoki girazoki deleted the girazoki-fix-author-inherent-benchmark branch July 18, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants