Skip to content

Fix checksum #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moravveji merged 2 commits into from
Jun 28, 2024
Merged

Fix checksum #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12e57e3
Test: Improve checksum error message
Flamefire Jun 27, 2024
0aa6231
Fix checksum of signal extension
Flamefire Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions easybuild/easyconfigs/r/R-bundle-CRAN/R-bundle-CRAN-2024.06-foss-2023b.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1595,8 +1595,8 @@ exts_list = [
'checksums': ['7c849086cb17d6c5aefc106217363e14afbcda2a9e0120687d40805b5e1c566a'],
}),
('signal', '1.8-0', {
'checksums': ('0a604949bae91410a150a22cfa02d954f5b83166cc7a73e5409554d00e0417a7', # older source
'23ff303856ff09734e8ef280cec94556a15cdc702727ae5d02f8cfa4d8f473b7'), # newer source
'checksums': [('0a604949bae91410a150a22cfa02d954f5b83166cc7a73e5409554d00e0417a7', # older source
'23ff303856ff09734e8ef280cec94556a15cdc702727ae5d02f8cfa4d8f473b7')], # newer source
}),
('tuneR', '1.4.7', {
'checksums': ['364154a0440953327eeefd2f3c72c9f819944cbb52b6e7497958882ca0b6960a'],
Expand Down
6 changes: 3 additions & 3 deletions test/easyconfigs/easyconfigs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,7 +1005,7 @@ def test_easyconfig_locations(self):
if not easyconfig_dirs_regex.search(dirpath):
# only exception: TEMPLATE.eb
if not (dirpath.endswith('/easybuild/easyconfigs') and filenames == ['TEMPLATE.eb']):
self.assertTrue(False, "List of easyconfig files in %s is empty: %s" % (dirpath, filenames))
self.fail("List of easyconfig files in %s is empty: %s" % (dirpath, filenames))

def test_easyconfig_name_clashes(self):
"""Make sure there is not a name clash when all names are lowercase"""
Expand All @@ -1026,7 +1026,7 @@ def test_easyconfig_name_clashes(self):
duplicates[name] = names[name]

if duplicates:
self.assertTrue(False, "EasyConfigs with case-insensitive name clash: %s" % duplicates)
self.fail("EasyConfigs with case-insensitive name clash: %s" % duplicates)

@skip_if_not_pr_to_non_main_branch()
def test_pr_sha256_checksums(self):
Expand Down Expand Up @@ -1063,7 +1063,7 @@ def test_pr_sha256_checksums(self):
retained_changed_ecs.append(ec)

checksum_issues = check_sha256_checksums(retained_changed_ecs, whitelist=whitelist)
self.assertTrue(len(checksum_issues) == 0, "No checksum issues:\n%s" % '\n'.join(checksum_issues))
self.assertEqual(len(checksum_issues), 0, "Found checksum issues:\n" + '\n'.join(checksum_issues))

@skip_if_not_pr_to_non_main_branch()
def test_pr_python_packages(self):
Expand Down