Add get_first_trip_stop function for run_stop#306
Merged
felixguendling merged 1 commit intomotis-project:masterfrom Jan 29, 2026
Merged
Add get_first_trip_stop function for run_stop#306felixguendling merged 1 commit intomotis-project:masterfrom
felixguendling merged 1 commit intomotis-project:masterfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
get_first_trip_stopfunction forrun_stopthe same wayget_last_trip_stopalready exists.I merely copied the structure of
get_last_trip_stop, adapted it for the first stop case, and simplified a little bit the function (contrary toget_last_trip_stopthat needs to do some index checks because ofsection_idxusingstop_idx_ - 1,get_first_trip_stoponly depends onstop_idx_so less boundary checks need to be done).Please proofread carefully my yet simple PR. I have little experience with all the nigiri code.