Include mutex header for usage of scoped_lock #3532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since std::scoped_lock is used in the implementations, the header defining this should be included.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3532 +/- ##
==========================================
+ Coverage 46.23% 46.23% +0.01%
==========================================
Files 720 720
Lines 62717 62714 -3
Branches 7595 7594 -1
==========================================
+ Hits 28988 28990 +2
+ Misses 33562 33556 -6
- Partials 167 168 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjahr
approved these changes
Jul 22, 2025
Markus-Simonsen
pushed a commit
to Markus-Simonsen/moveit2
that referenced
this pull request
Aug 12, 2025
Since std::scoped_lock is used in the implementations, the header defining this should be included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since std::scoped_lock is used in the implementations, the header defining this should be included.
Otherwise this can lead to build errors such as in https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/actions/runs/16434641652/job/46442308076#step:6:9912
Could also reproduce this when building moveit2 locally. Adding the changes from this PR fixed it.