Skip to content

Conversation

@eholum
Copy link
Member

@eholum eholum commented Aug 9, 2025

Description

MoveIt's iMarker doesn't initialize the marker namespace property, so that functionality is broken when you try to add other iMarkers alongside moveit's planning interface. Normally this just breaks the cursor, though in some cases we've seen rviz crash. I was under the impression that pluginlib might still load the default plugin for other markers, but that does not seem to be the case.

Regardless, I don't think there's a downside to providing the node abstraction to the namespace property object, so this PR just uncomments those lines.

Before (cursor gets stuck as a spinning wheel):

Screen.Recording.2025-08-09.at.10.47.21.AM.mov

After:

Screen.Recording.2025-08-09.at.10.49.49.AM.mov

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@eholum eholum self-assigned this Aug 9, 2025
@eholum eholum added the bug Something isn't working label Aug 9, 2025
@codecov
Copy link

codecov bot commented Aug 9, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.22%. Comparing base (7d6e2ab) to head (513fc43).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ing_rviz_plugin/src/interactive_marker_display.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3547      +/-   ##
==========================================
- Coverage   46.22%   46.22%   -0.00%     
==========================================
  Files         720      720              
  Lines       62713    62717       +4     
  Branches     7594     7595       +1     
==========================================
  Hits        28985    28985              
- Misses      33562    33566       +4     
  Partials      166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code was copied over from rviz in #342 where @JafarAbdi apparently commented that section to avoid using the rviz node abstraction.
The handle here is only used to select the potential values for the property, so using the rviz handle for that should be fine.

@v4hn v4hn merged commit 3e526af into moveit:main Aug 10, 2025
9 of 10 checks passed
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Aug 10, 2025
@eholum eholum added backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy labels Aug 11, 2025
mergify bot pushed a commit that referenced this pull request Aug 11, 2025
mergify bot pushed a commit that referenced this pull request Aug 11, 2025
Markus-Simonsen pushed a commit to Markus-Simonsen/moveit2 that referenced this pull request Aug 12, 2025
JafarAbdi pushed a commit that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants