-
Notifications
You must be signed in to change notification settings - Fork 698
Initialize the namespace property for custom iMarkers in rviz #3547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3547 +/- ##
==========================================
- Coverage 46.22% 46.22% -0.00%
==========================================
Files 720 720
Lines 62713 62717 +4
Branches 7594 7595 +1
==========================================
Hits 28985 28985
- Misses 33562 33566 +4
Partials 166 166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
v4hn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code was copied over from rviz in #342 where @JafarAbdi apparently commented that section to avoid using the rviz node abstraction.
The handle here is only used to select the potential values for the property, so using the rviz handle for that should be fine.
(cherry picked from commit 3e526af)
(cherry picked from commit 3e526af)
…#3550) (cherry picked from commit 3e526af) Co-authored-by: Erik Holum <[email protected]>
Description
MoveIt's iMarker doesn't initialize the marker namespace property, so that functionality is broken when you try to add other iMarkers alongside moveit's planning interface. Normally this just breaks the cursor, though in some cases we've seen rviz crash. I was under the impression that pluginlib might still load the default plugin for other markers, but that does not seem to be the case.
Regardless, I don't think there's a downside to providing the node abstraction to the namespace property object, so this PR just uncomments those lines.
Before (cursor gets stuck as a spinning wheel):
Screen.Recording.2025-08-09.at.10.47.21.AM.mov
After:
Screen.Recording.2025-08-09.at.10.49.49.AM.mov
Checklist