Skip to content

Conversation

@mini-1235
Copy link
Contributor

Description

Hi, after ros/pluginlib#165 is merged, we can list all plugins by using

ros2 plugin list

However, I encountered an error when listing moveit's plugins due to the malformed XML

moveit_kinematics:
Traceback (most recent call last):
  File "/opt/ros/rolling/bin/ros2", line 33, in <module>
    sys.exit(load_entry_point('ros2cli==0.40.1', 'console_scripts', 'ros2')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/ros/rolling/lib/python3.12/site-packages/ros2cli/cli.py", line 91, in main
    rc = extension.main(parser=parser, args=args)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/pluginlib_ws/build/ros2plugin/ros2plugin/command/plugin.py", line 37, in main
    return extension.main(args=args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/pluginlib_ws/build/ros2plugin/ros2plugin/verb/list.py", line 69, in main
    tree = ET.parse(plugin_xml)
           ^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/xml/etree/ElementTree.py", line 1204, in parse
    tree.parse(source, parser)
  File "/usr/lib/python3.12/xml/etree/ElementTree.py", line 569, in parse
    self._root = parser._parse_whole(source)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
xml.etree.ElementTree.ParseError: not well-formed (invalid token): line 2, column 129

This PR fixes the issue

moveit_kinematics:
        Plugin(name='kdl_kinematics_plugin/KDLKinematicsPlugin', type='kdl_kinematics_plugin::KDLKinematicsPlugin', base='kinematics::KinematicsBase')
        Plugin(name='srv_kinematics_plugin/SrvKinematicsPlugin', type='srv_kinematics_plugin::SrvKinematicsPlugin', base='kinematics::KinematicsBase')
        Plugin(name='cached_ik_kinematics_plugin/CachedKDLKinematicsPlugin', type='cached_ik_kinematics_plugin::CachedIKKinematicsPlugin<kdl_kinematics_plugin::KDLKinematicsPlugin>', base='kinematics::KinematicsBase')
        Plugin(name='cached_ik_kinematics_plugin/CachedSrvKinematicsPlugin', type='cached_ik_kinematics_plugin::CachedIKKinematicsPlugin<srv_kinematics_plugin::SrvKinematicsPlugin>', base='kinematics::KinematicsBase')
moveit_planners_chomp:
        Plugin(name='chomp_interface/CHOMPPlanner', type='chomp_interface::CHOMPPlannerManager', base='planning_interface::PlannerManager')

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mini-1235
Copy link
Contributor Author

@nbbrooks Can you take a look on this PR :)

Copy link
Member

@EzraBrooks EzraBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this was obviously wrong. thanks for the fix!

@EzraBrooks EzraBrooks enabled auto-merge (squash) November 25, 2025 21:26
@EzraBrooks EzraBrooks merged commit 76ac75f into moveit:main Nov 25, 2025
8 of 9 checks passed
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.17%. Comparing base (7508895) to head (eced960).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3599      +/-   ##
==========================================
- Coverage   46.20%   46.17%   -0.02%     
==========================================
  Files         720      720              
  Lines       59180    59180              
  Branches     7595     7595              
==========================================
- Hits        27338    27323      -15     
- Misses      31674    31691      +17     
+ Partials      168      166       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants