Skip to content

Conversation

@mfruhner
Copy link

@mfruhner mfruhner commented Dec 9, 2025

Add check to skip joints not in RobotModel

Description

I backported the changes of #2222 to humble. This prevents printing error messages when the robot_model contains more joints than just the robot arm.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Add check to skip joints not in RobotModel
@mergify
Copy link

mergify bot commented Dec 9, 2025

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

@EzraBrooks
Copy link
Member

very odd that mergify refuses to backport the original PR to humble..

Copy link
Member

@EzraBrooks EzraBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen this in the wild too. Thanks for backporting!

@EzraBrooks
Copy link
Member

oop, spoke too soon - needs a pre-commit format

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 51.21%. Comparing base (ac933b6) to head (fe00f83).
⚠️ Report is 3 commits behind head on humble.

Files with missing lines Patch % Lines
...anning_scene_monitor/src/current_state_monitor.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #3634      +/-   ##
==========================================
+ Coverage   51.20%   51.21%   +0.01%     
==========================================
  Files         407      407              
  Lines       30665    30667       +2     
==========================================
+ Hits        15700    15704       +4     
+ Misses      14965    14963       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mfruhner
Copy link
Author

oop, spoke too soon - needs a pre-commit format

sorry for that. Should be fixed now.

@stephanie-eng stephanie-eng merged commit fec72cb into moveit:humble Dec 12, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants