Skip to content

Conversation

@stephanie-eng
Copy link
Contributor

Description

This lovely set of tests appears to be causing some issues in CI.

Rather than doing init and shutdown for each test, let's init once and shutdown once. I'm not a wizard enough to understand why this suddenly started failing, but I think it's a good idea to init and shutdown like the other tests do.

@stephanie-eng
Copy link
Contributor Author

Hoping this will fix CI failures in #3628 #3620 #3635 #3636 #3626 #3631

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.18%. Comparing base (2002fb7) to head (b6c95fd).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3637      +/-   ##
==========================================
+ Coverage   46.11%   46.18%   +0.08%     
==========================================
  Files         726      726              
  Lines       59371    59367       -4     
  Branches     7614     7615       +1     
==========================================
+ Hits        27373    27414      +41     
+ Misses      31831    31786      -45     
  Partials      167      167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@EzraBrooks EzraBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the global context really do be that way

How did this ever work? Thanks for finding and fixing it!

@EzraBrooks EzraBrooks merged commit 2f93d82 into moveit:main Dec 11, 2025
12 of 14 checks passed
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants