Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Dec 11, 2025

Description

If I were to use SetRobotTrajectoryMsg, to set a trajectory message, it appears that only positions are handled for multidof joints, and velocity/acceleration information is discarded.

This change handles the contents of multidof joint trajectories similarly to done here and populates the velocities and accelerations in the robot states. I've also taken the liberty of adding a test to ensure that the multidof joint trajectory positions and accelerations appear as expected.

This currently doesn't support angular/x or angular/y, for which I've added a comment noting this.

As a note, I tested this on Jazzy. I currently don't have a rolling build going, but I don't think things look that different in this part of the code base anyway.


This is an automatic backport of pull request #3635 done by Mergify.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.23%. Comparing base (1ade0e9) to head (85c30ca).
⚠️ Report is 2 commits behind head on jazzy.

Files with missing lines Patch % Lines
...eit_core/robot_trajectory/src/robot_trajectory.cpp 87.50% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3638      +/-   ##
==========================================
+ Coverage   46.18%   46.23%   +0.05%     
==========================================
  Files         718      718              
  Lines       59109    59156      +47     
  Branches     7589     7595       +6     
==========================================
+ Hits        27292    27343      +51     
+ Misses      31652    31648       -4     
  Partials      165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephanie-eng stephanie-eng merged commit 703f6da into jazzy Dec 12, 2025
8 checks passed
@stephanie-eng stephanie-eng deleted the mergify/bp/jazzy/pr-3635 branch December 12, 2025 04:29
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants