Skip to content

Conversation

@stephanie-eng
Copy link
Contributor

@stephanie-eng stephanie-eng commented Dec 12, 2025

Remove CLANG_TIDY_ARGS to support run-clang-tidy
Also pin industrial_ci to a specific commit hash, so that way we can break things when we want to, and not when someone else pushes something.

I haven't tested this at all, so I'm just hoping that this is the sum total of all the things we need to get to green checks again.

Also update industrial_ci action to a specific commit hash for stability.
@EzraBrooks
Copy link
Member

I suspect it's going to fail on "upload clang-tidy changes" since I think that is expecting some files to exist that will exist no longer after this change?

Not that anyone ever looked at those clang-tidy changes, I don't think - we can likely remove them.

The PR that merged upstream was actually entirely intended to get rid of that sort of workaround and allow people to use the built-in "fixes file" feature in clang-tidy.

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.20%. Comparing base (6d020ab) to head (b9a12ba).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3640      +/-   ##
==========================================
+ Coverage   46.17%   46.20%   +0.03%     
==========================================
  Files         726      726              
  Lines       59419    59413       -6     
  Branches     7619     7621       +2     
==========================================
+ Hits        27433    27446      +13     
+ Misses      31820    31800      -20     
- Partials      166      167       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@EzraBrooks EzraBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well it passed anyway so whatever

@EzraBrooks EzraBrooks merged commit 7fd2e46 into moveit:main Dec 13, 2025
9 of 10 checks passed
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Dec 13, 2025
@stephanie-eng stephanie-eng added the backport-jazzy Mergify label that triggers a PR backport to Jazzy label Dec 14, 2025
mergify bot pushed a commit that referenced this pull request Dec 14, 2025
Also update industrial_ci action to a specific commit hash for stability.

(cherry picked from commit 7fd2e46)
@stephanie-eng stephanie-eng added the backport-humble Mergify label that triggers a PR backport to Humble label Dec 14, 2025
mergify bot pushed a commit that referenced this pull request Dec 14, 2025
Also update industrial_ci action to a specific commit hash for stability.

(cherry picked from commit 7fd2e46)

# Conflicts:
#	.github/workflows/ci.yaml
stephanie-eng added a commit that referenced this pull request Dec 14, 2025
Attempt to unbork CI round 2 electric boogaloo (backport #3640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Mergify label that triggers a PR backport to Humble backport-jazzy Mergify label that triggers a PR backport to Jazzy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants