-
Notifications
You must be signed in to change notification settings - Fork 695
Attempt to unbork CI round 2 electric boogaloo #3640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also update industrial_ci action to a specific commit hash for stability.
|
I suspect it's going to fail on "upload clang-tidy changes" since I think that is expecting some files to exist that will exist no longer after this change? Not that anyone ever looked at those clang-tidy changes, I don't think - we can likely remove them. The PR that merged upstream was actually entirely intended to get rid of that sort of workaround and allow people to use the built-in "fixes file" feature in clang-tidy. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3640 +/- ##
==========================================
+ Coverage 46.17% 46.20% +0.03%
==========================================
Files 726 726
Lines 59419 59413 -6
Branches 7619 7621 +2
==========================================
+ Hits 27433 27446 +13
+ Misses 31820 31800 -20
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EzraBrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well it passed anyway so whatever
Also update industrial_ci action to a specific commit hash for stability. (cherry picked from commit 7fd2e46)
Also update industrial_ci action to a specific commit hash for stability. (cherry picked from commit 7fd2e46) # Conflicts: # .github/workflows/ci.yaml
Attempt to unbork CI round 2 electric boogaloo (backport #3640)
Remove
CLANG_TIDY_ARGSto support run-clang-tidyAlso pin industrial_ci to a specific commit hash, so that way we can break things when we want to, and not when someone else pushes something.
I haven't tested this at all, so I'm just hoping that this is the sum total of all the things we need to get to green checks again.