VPN-2199: Windows ARM Support#10891
Merged
Merged
Conversation
6841d67 to
173bab7
Compare
173bab7 to
6ba0446
Compare
9908c5f to
fc3ce2d
Compare
b4f370f to
3fcaa88
Compare
15e330e to
c5a7658
Compare
c5a7658 to
5dbdae4
Compare
0acff9e to
638dddd
Compare
25dd095 to
041b370
Compare
c1e2dbd to
5434076
Compare
5e59ce8 to
3276fd0
Compare
4a35381 to
0b4bac0
Compare
0b4bac0 to
b4178c7
Compare
strseb
reviewed
Dec 10, 2025
strseb
reviewed
Dec 10, 2025
| implementation: generic-worker | ||
| os: windows | ||
| worker-type: b-win2022 | ||
| b-win11-2024h2-arm64: |
Collaborator
There was a problem hiding this comment.
RN we only have level-1 Workers, we should followup with releng, that we also get the level-3 queue up before we merge this, otherwise those tasks will be stuck :)
strseb
reviewed
Dec 10, 2025
Collaborator
There was a problem hiding this comment.
I think this breaks the tc-ios tasks :c
Collaborator
Author
There was a problem hiding this comment.
Looks like the change that broke things was getsentry/sentry-native#1083 which got released in sentry-native 0.7.14. We could probably just revert that back to 0.7.13 to get unstuck, which still includes the fixes for Windows arm64.
strseb
approved these changes
Dec 10, 2025
Collaborator
strseb
left a comment
There was a problem hiding this comment.
Amazing stuff, thank you so much!!
4f23f04 to
3819926
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This should get most of the way towards producing an arm64 build for Windows. Much of the heavy lifting to get here was previously done by the work to get cross-compilation to Windows working from Linux.
This PR:
aarch64-pc-windows-msvctarget.x86_64-toolchain.cmakeandaarch64-toolchain.cmakex64andarm64targets of the windows SDK into the cross conda environment.cl.exewithclang-clfor ARM64 Windows builds briansmith/ring#2216I am currently struggling a bit to figure out how to package the resulting artifacts as an MSI installer, so I think I am going to leave that piece for a future PR.
Reference
JIRA Issue: VPN-2199
Depends on: briansmith/ring#2216
Depends on: Bugzilla 1944293
Checklist